Seneschal Report - July 2018
In which James talks about recent changes to the site, once again copy/pastes a change-log, and talks about upcoming coding-related things on the horizon.
Time for another report from your friendly neighborhood Seneschal with the latest ins and outs related to the site.
Deployed Code Changes
Below is a list of most of the code check-ins done to the site since my last report. This is a non-exhaustive, automatically generated list, and does not contain code changes that have not yet been deployed to the main website, nor does it list code changes that are outside the scope of the main website.
Here are some highlights:
- GFX Society
- GDPR compliancy
- Possessions item upgrade code
- ACC Extensions revamp
- Internal framework and library updates
- Send site-generated e-mails as originating from a darkjedibrotherhood.com e-mail address to decrease the chance of our e-mails getting tagged as spam
- Various bug fixes and misc changes
James Entar: Feature: Hybrid Factions GFX Society initial logic CS: Fix aspects and feats pulling character name from current dossier rather than CS/snapshot metadata CS: Fix wizard displaying linguistics level instead of lore level in lore explanation paragraph Update Kallisto for new Google export format Color competition label by status Treat Rogue members that are in a position as 'not rogue' for the purpose of hiding e-mail addresses Possessions: Item Upgrade feature Reflect Item Upgrade wording on Item Research pages Tag Telegram broadcast with unit Add unit icon to news items Show item aspect type on admin listing page Allow VOICE staff to create/manage Faction NPCs Re-introduce search on inventory management pages Prevent duplicate ACC reminders after staff posts Fix a typo Fix 500 error when trying to clone a competition with unexpected metadata Show a warning if CS metadata is out of date when creating snapshots, submitting/responding to ACC challenges, or submitting fiction entries Change unit performance report competition date cutoff Fix Kallisto still considering banned members as list subscribers and trying to get them removed Add line break to Markdown cheat sheet CS: Show warning when selecting/browsing feats that require skills/powers that don't have any points put into them Regererate ItemPrototype slug on name change Allow showing subunit leaders on leadership section of unit page Show staff mailing list addresses on DC page CSS fix Add link to wiki for 'cs out of date' warning Fix ACC start-of-battle post not scheduling a reminder mail Regenerate Faction slug/url after faction name change Escape quotes in og:title meta property Add breadcrumbs to competition administration pages Update upstream libraries Upgrade framework to Rails 5.1.5 Fix deprecation warnings due to framework update Fix CS strong parameters issue due to framework update Change forced association reloading to new method (framework deprecation) Fix some queries being generated incorrectly (framework deprecation) Fix gaming match validaton being overly strict (framework deprecation) Fix SA exams not saving due to Strong Params (framework deprecation) Don't show inactive house QUAs on clan pages Kallisto fixes for Ruby 2.5 Change member distribution policy for recruited members to follow the distribution policy of the recruiter's root unit rather than recruiter's actual unit Fix CS preview pulling name from dossier/npc record instead of CS record Update text on 'email not working' alert to refer to MAA instead of RM Fix bugs introduced by Rails 5.1 upgrade Fix ACC battles refusing to start Refactor unit statistics report Add job vacancy board Disable summit access to unit performance reports Hide Telegram join links unless logged in Add competition types to unit stats report Update probation display to respect tolling mechanism Add withdrawn comps to 'unsubmitted' count Fix ambiguous column in query Fix incorrect path when throwing error on extension requests Fix unit statistics report limit Fix SCL/Regent staff being unable to access entities that have no defined owner, such as the NPC Armory Allow updating item aspects to public Implement 'A solid 5/7' trophy Set up permissions for Social Media Tribune Regression: fix removing Docents from courses; Add inverse-of relations to work around Rails 5 bug Guide people towards the Advancement Survey if they haven't taken it yet Show recruitment link info on signups overview Prep GFX Society Launch Minor fixes; fix bonus CI Let the site know about position term limits Add recruiter to post-ToI-transfer e-mail Tighten security a bit Swap CS wizard steps around Add some more meta keywords Add a column to Mav stats report Expand ACC post comments by default once a battle is judged ACC: Advantage scoring feature GDPR changes Small stylesheet fix Fix join form Disable organizer and co-organizer credits for container competitions Update P:MAA permissions Refactor CS/Possessions gender placeholders Add some dev documentation helper stuff Update gender selector Fix Herald comp emails not CCing Herald staff Disable Avantage again for some ACC score categories Reorder the Admin homepage a bit Prep incoming e-mail webhook Email relay feature Switch CS and ACC mails over to new sender format Don't keep retrying to relay spammy mails Migrate the rest of the mailers Revamp ACC Extension system to work through the site instead of e-mails Remove deprecated ACC routes Remove public-facing mentions of Prestige Add missing warbanner category to gfx request overview Temporarily disable PvO/PvE portal (maintenance) Revert "Temporarily disable PvO/PvE portal (maintenance)" Fix ACC post preview not working due to still pointing to a removed URL route Add "Bob Ross Fan" Trophy Sort trophies by recent when clicking on trophy notification Fix snapshot listing not working when an associated ACC battle or competition is deleted Shrink big images in Markdown content to fit container Add ability to hide competition prompts until a competition starts SA admin backend tweaks and tools Add additional statistics to SA course admin Improve competition participation overview filters Accidentally a submit button
On the Horizon
This section provides some sneak previews of upcoming site changes and the larger things on the Seneschal Office's todo-list in various stages of completion, in no particular order.
The big "When we get to it" list
Random small or less small things the Seneschal office tackles when they have spare time. Feel free to mail/message me with any suggestions for this list.
- Update CSS and templates to Bootstrap 4
- Order and/or path specific 'aliases' for Titles
- Better monitoring and automated restarting for various processes, such as the FIST-bot
- Look at the 'relevant to me' filter on competition page, which still contains hold-overs from the time when we had Independent Houses
- Extended filters for the dossier DJB history listing page
- Look at default ordering/sorting of items in containers and/or clan OOBs
- Another round of library/framework updates
Assorted items that are being considered for implementation in the future. These likely require input from other offices before development can start
- "Easy-start" Character Sheet generator for first-time users. This should allow generating a CS based on a set of templates after answering a few simple questions. Users can then use the generated sheet as-is, or open it in the regular editor and go from there.
- Recruitment Incentive System
- Re-work the way Paths and Orders work
- New Trophies, and possibly adding additional credit rewards to existing Trophies
- Promotion Points™
Random Bug fixes and Things That Come Up™
A wild Dark Council member appeared. It uses Feature Request!
Once more, lots of fixes and additions, and even more interesting things to come. If you have any questions or suggestions, feel free to e-mail me, Telegram me, or throw in a comment.
James L. Entar
Seneschal of the Brotherhood